You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The return type for get_user_contexts method appears incorrect. Based on the tests, it returns a Hash with 'userContexts' key containing an array, not an Array directly.
Why: The type signature correction is crucial as it fixes a mismatch between the actual implementation and its type definition. The integration tests clearly show that get_user_contexts returns a Hash with a 'userContexts' key, not a plain Array.
High
General
Add parameter validation
Add input validation for the user_context parameter to ensure it's not nil or empty before making the API call
def remove_user_context(user_context)
+ raise ArgumentError, 'user_context cannot be nil or empty' if user_context.nil? || user_context.empty?
@bidi.send_cmd('browser.removeUserContext', userContext: user_context)
end
Apply this suggestion
Suggestion importance[1-10]: 7
__
Why: Adding input validation for the user_context parameter is a good defensive programming practice that can prevent cryptic errors and provide clearer error messages to users. The tests show that this parameter is critical for the method's functionality.
aguspe
changed the title
Create browser module, added user context related methods
[rb][BiDi] Create browser module, added user context related methods
May 7, 2025
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
aguspe
changed the title
User description
Motivation and Context
This PR is a continuation to add full support for the BiDi protocol for the ruby bindings
It adds the browser module and the following methods:
For more information here is the BiDi documentation: https://w3c.github.io/webdriver-bidi/#command-browser-createUserContext
Types of changes
Checklist
PR Type
Enhancement, Tests
Description
Added a new
Browsermodule to the BiDi implementation.Implemented user context management methods:
create_user_context,get_user_contexts, andremove_user_context.Introduced integration tests for the
Browsermodule's user context methods.Added type signatures for the
Browsermodule in RBS.Changes walkthrough 📝
bidi.rb
Add autoload for Browser modulerb/lib/selenium/webdriver/bidi.rb
Browsermodule.browser.rb
Add Browser class with user context methodsrb/lib/selenium/webdriver/bidi/browser.rb
Browserclass under the BiDi module.create_user_context,get_user_contexts, andremove_user_context.browser.rbs
Add type signatures for Browser modulerb/sig/lib/selenium/webdriver/bidi/browser.rbs
Browserclass and its methods.browser_spec.rb
Add integration tests for Browser modulerb/spec/integration/selenium/webdriver/bidi/browser_spec.rb
create_user_context,get_user_contexts,and
remove_user_context.